Clean out redundant stub overwrites - #6243
Merged
Merged
Conversation
AJenbo
marked this pull request as draft
August 22, 2026 01:57
AJenbo
marked this pull request as ready for review
August 22, 2026 02:49
Collaborator
|
This pull request has been marked as ready for review. |
AJenbo
marked this pull request as draft
August 22, 2026 03:18
ondrejmirtes
requested changes
Aug 22, 2026
AJenbo
force-pushed
the
master
branch
3 times, most recently
from
August 22, 2026 12:24
4bc98bd to
b9abf88
Compare
Member
|
Dynamic throw type extension could take care of that. |
Contributor
Author
|
Yeah, I'll make a separate PR for that. |
Contributor
Author
|
I belive the two failing tests are external issues. |
AJenbo
marked this pull request as ready for review
August 22, 2026 12:39
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
approved these changes
Aug 23, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean ups of things I upstreamed