Repository navigation
fix: restrict missing component attributes to declared I/O fields - #301
Open
toby-coleman wants to merge 2 commits into
Open
toby-coleman wants to merge 2 commits into
toby-coleman wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Benchmark comparison for |
|
Benchmark comparison for |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading an unknown public component attribute currently returns None, so misspelled fields also appear to exist through hasattr. Restrict that fallback to declared public inputs and outputs on the instance's current IOController. Unknown attributes now raise AttributeError with the component class, instance name, and field name.
Declared-but-unset ports continue returning None without assigning a value or making inputs ready. Explicitly assigning None retains an instance attribute. Runtime declarations from FileReader and FileWriter follow the same rules as static and inherited ports. Document this contract and add regression coverage for attribute lookup, dynamic instance isolation, initialization, export/reconstruction, and deepcopy.
Preserve the helpful ValidationError for components that omit super().init(). The missing name is now detected when the component ID is accessed during process construction, rather than later during process initialization.