conformance: stripe the polyengine-deno leg across Deno Web Worker shards - #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the shard item from #372 (the last unchecked leg-level lever): the polyengine-deno conformance leg — the matrix's only unstriped target and the conformance job's measured tail (263s shared-suite on the 4-vCPU runner, per run 32652990970) — now fans its case loop across Deno Web Worker shards using ct-runner 0.5.0's
shardoption (polymorph-components/polyengine#110, already pinned by the frozen import map;deno.lockuntouched).The topology is the one
RunSuiteOptions.shard's doc comment documents: onerunSuitecall per worker with stripei % countover census order; each shard emits its own envelope and terminator; the parent (run.ts) keeps one envelope — asserting every shard's is byte-identical, which also catches divergent artifact reads since the envelope embedsartifact-sha256— reorders rows by the per-row census indexemitnow passes, writes the single terminator, and sums the per-shard counts. Execution moves toshard-worker.ts(translator + host-import wiring per worker);run.tskeeps CLI, suite specs, merge, and reporting.--shards Noverrides the default (core count capped at 8);--shards 1runs unsharded in a single worker. Containment is unchanged in kind: still one component instance perrunSuitecall (freshCases: false, the header's recorded trade), now bounded per shard stripe rather than per suite, and--fresh-casesstill restores per-case containment.The two suites keep running as concurrent processes (the #373 interim step); the stale "ct-runner has no shard option yet" justfile paragraph is rewritten to describe the shipped mechanism.
Verification:
duration-msfield (counts identical: 18756/33/0/302 shared, 686/84/0/2 signing);--shards 1likewise.just conformance-ct::allgreen end to end: 8 targets / 76,364 shared results and 7 targets / 2,316 signing results, 0 failing beyond declared expected-fail, 0 validation errors — the merged JSONL satisfies the aggregate's lockfile identity.deno task check(run.ts, shard-worker.ts, browser entries) andjust conformance-ct::polyengine-pin-checkpass.Local wall (18 cores, shards=8): shared 22.2s → 19.0s–10.7s depending on phase load, signing 3.0s → 1.0–2.6s; the local win is bounded by per-worker boot (translate + census enumeration). On the 4-vCPU runner the case work dominates (263s), so the expected tail is ~90–120s at 4 shards, per #372's estimate.
Part of #372 (the wizer adoption and cache-key items remain).