Repository navigation
Conversation
3 tasks
teunbrand
commented
Oct 22, 2026
Comment on lines
+173
to
+175
| /// Constant channels from layer parameters, scale-bypassing (e.g. | ||
| /// `start_marker`/`end_marker` from the `arrow` SETTING). | ||
| pub constants: Vec<(&'static str, HValue)>, |
Collaborator
Author
There was a problem hiding this comment.
If there is already a pre-existing path parameters should take, we should use that instead.
teunbrand
commented
Oct 22, 2026
Comment on lines
+278
to
+286
| // Same rationale as the aggregate check above: surface `arrow` | ||
| // vocabulary errors without executing. | ||
| if let Err(e) = crate::plot::layer::geom::types::validate_arrow_param(&layer.parameters) | ||
| { | ||
| errors.push(ValidationError { | ||
| message: format!("{}: {}", context, e), | ||
| location: None, | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Ideally this should be validated along with other parameters, but it doesn't quite fit into the constraint system due to the numeric suffixes e.g. 'closed:10'. Perhaps a constraint of the constraint system...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an entry in #530.
Briefly this allows
SETTING arrow => 'open'in line, path and segment geometries.By default, this sets the end arrow and when using length-2 array e.g.
['open', 'open']it sets the start and end arrows.We take hephaestus arrows, but omit the
arrow-prefix.Arrow size by default is hephaestus' default (3x linewidth), but size can also be set by using a numeric suffix, e.g.
'open:10'.