Repository navigation
Fix unintended bubbling of inherited object property names - #175
Merged
ai merged 1 commit intoOct 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom at-rules named
constructorortoStringare currently treated as built-in bubbling rules because the lookup table inherits Object.prototype. This moves their content out of its original scope even when they are not configured to bubble.Use a prototype-free lookup table. Regression tests cover preserving those custom blocks and honoring an explicit bubble configuration.
Validation: the added regression fails before the fix; all 76 tests pass afterwards with
node node_modules/better-node-test/bin.js --coverage 100(100% line/function coverage). Oxlint reports the existing no-redeclare error in unchanged index.d.ts; neither changed file has a lint diagnostic.