Repository navigation
Always auto-move patches tagged Bugfix when a commitfest closes - #120
Merged
Merged
Conversation
Bug fixes that had a quiet thread or a red CI stayed behind in the closed commitfest, where nobody looks for them. Move every open patch tagged Bugfix to the next commitfest, whatever its activity or CI state. Requested by Álvaro Herrera: https://www.postgresql.org/message-id/ar4QFqNuUX-e0v2B%40alvherre.pgsql
JelteF
reviewed
Oct 18, 2026
| assert QueuedMail.objects.count() == 0 | ||
|
|
||
|
|
||
| def test_no_auto_move_for_other_tags_without_email_activity( |
Collaborator
There was a problem hiding this comment.
This test seems unnecessary
JelteF
reviewed
Oct 18, 2026
|
|
||
|
|
||
| def test_auto_move_bugfix_when_failing_too_long(alice, in_progress_cf, open_cf): | ||
| """Patches tagged Bugfix should be auto-moved even if CI has been failing too long.""" |
Collaborator
There was a problem hiding this comment.
Let's combine this test with the test above.
JelteF
approved these changes
Oct 18, 2026
The two Bugfix tests only differed in whether CI was also failing for too long, so a single test of a Bugfix patch that is both inactive and failing covers both bypassed conditions. The test checking that other tags don't trigger auto-move is dropped, since `test_no_auto_move_without_email_activity` already covers the normal path and the tag check is an explicit name match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Álvaro pointed out on pgsql-hackers1 that bug fixes get lost in closed commitfests, because the auto-move rules skip patches whose thread is quiet or whose CI has been failing for too long. Now every open patch tagged Bugfix is moved to the next commitfest when a commitfest closes, regardless of activity or CI state.