Repository navigation
Search pgsql-bugs too when attaching a thread - #121
Merged
Merged
Conversation
The "Attach thread" search only looked at pgsql-hackers, so a patch for a bug report could only be attached by pasting a message id. Search every list in ARCHIVES_SEARCH_LISTS, which is pgsql-hackers and pgsql-bugs by default, and merge the results. Fixes postgres#117
JelteF
reviewed
Oct 18, 2026
Comment on lines
+160
to
+161
| # Mailing lists searched when attaching a thread to a patch | ||
| ARCHIVES_SEARCH_LISTS = ["pgsql-hackers", "pgsql-bugs"] |
Collaborator
There was a problem hiding this comment.
I don't think this needs to be configurable. we can just define this inline in the place this is used.
JelteF
approved these changes
Oct 18, 2026
There's no real need for deployments to configure which lists are searched when attaching a thread, so the `ARCHIVES_SEARCH_LISTS` setting is replaced by an inline tuple in `getThreads`. The two tests are folded into one that covers merging, deduplication, ordering and the 100 result cap at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
The "Attach thread" search only looked at pgsql-hackers, so a patch for a bug report could only be attached by pasting its message id. Now it searches pgsql-bugs too, and merges the results newest first.