Repository navigation
fix: keep parens around intersection types inside unions - #2544
Closed
Dextheking1 wants to merge 4 commits into
Closed
Dextheking1 wants to merge 4 commits into
Dextheking1 wants to merge 4 commits into
Conversation
Dextheking1
marked this pull request as ready for review
October 23, 2026 02:14
Contributor
Author
|
closing this, #2470 already covers it and was first. the tests/dnf-types fixture in here might be useful for it, feel free to take it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(A&B)|Clost its parens when printed, so the output wasA&B|C. That is a parse error in PHP. DNF types need the parens around the intersection part.Fix is in needs-parens: an intersectiontype inside a uniontype now keeps its parens. A standalone
(A&B)still drops them and prints asA&B.New fixture under tests/dnf-types covers param, return, closure and arrow function types.
Verified with jest: the new fixture passes and the full suite passes (102 suites, 596 tests). AST_COMPARE=1 also passes on the new fixture, so the output parses back.
Fixes #2450