Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change
Show TXT ownership instructions, Cloudflare proxy recovery, and a safe retry command when a custom domain cannot connect.
What's changed and why
domain-ownership-requiredasSERVICE.DOMAIN_OWNERSHIP_REQUIRED, with the exact DNS instructions from the API.domain-cloudflare-proxyasSERVICE.DOMAIN_CLOUDFLARE_PROXY. Explain DNS only during setup, then Proxied after Active with Full (strict) TLS and an accessible ACME challenge path. Preserve the same project, service, and branch when retrying.Stacked on #354 for branch-domain support. Companions: platform #5785 and docs #8581. Merge and release that PR first. Release this change before the platform TXT enforcement for clear recovery guidance; publish the companion public docs only after the platform deploy and CLI release.
Testing notes / Before-after
Before: the ownership error would be mistaken for a missing deployment. After: the CLI shows the workspace TXT instructions or Cloudflare-specific recovery and retries the same branch app.
Passed: root format, type checks (nine tasks), lint, error-reference completeness (132 codes), full CLI package suite (1,050 passed, one existing skip), and local end-to-end tests (seven passed). The 48 live API tests skip without a service token. No live DNS or TLS changes were made.