Skip to content

Add Hindi translation for Teachers Guide to p5.js v2 - #1533

Open
Ayush4958 wants to merge 2 commits into
processing:mainfrom
Ayush4958:translate-teacher-guide-in-hindi
Open

Add Hindi translation for Teachers Guide to p5.js v2#1533
Ayush4958 wants to merge 2 commits into
processing:mainfrom
Ayush4958:translate-teacher-guide-in-hindi

Conversation

@Ayush4958

@Ayush4958 Ayush4958 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

I have added the Hindi translation for the Teachers Guide to p5.js v2 tutorial src/content/tutorials/hi/v2_transition.mdx
Closes :- #1526

Screen Recording

Screen.Recording.2026-07-26.052719.mp4

cc: @ksen0 @Divyansh013

@Ayush4958

Copy link
Copy Markdown
Contributor Author

PR is ready for review
thanks ....

@Nwakaego-Ego

Copy link
Copy Markdown
Contributor

Hi @Ayush4958, thank you for this PR. Please add the issue number this PR addresses to the description so it is easier to track.

@Divyansh013, please review when you get a chance. Thank you.

@Ayush4958

Copy link
Copy Markdown
Contributor Author

Hi @Ayush4958, thank you for this PR. Please add the issue number this PR addresses to the description so it is easier to track.

@Divyansh013, please review when you get a chance. Thank you.

Added the related issue

@ksen0

ksen0 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Thanks @Ayush4958 ! Hi @Divyansh013 @ritiupa would either of you be able to review please? Thanks in advance!

@ksen0

ksen0 commented Aug 3, 2026

Copy link
Copy Markdown
Member

If there are no other reviewers in the next few days, @perminder-17 would you be able to take a look please? Many thanks!

@Divyansh013

Copy link
Copy Markdown
Member

Hi @ksen0 @Ayush4958 sorry for the delay, I was away from system from the last few days. I'll take a look today

@@ -0,0 +1,436 @@
---
title: "p5.js v2 के लिए शिक्षकों का मार्गदर्शन"
description: मध्य विद्यालय और उच्च विद्यालय के शिक्षकों के लिए पिछले संस्करणों के उपयोग से p5.js संस्करण 2 में परिवर्तन के लिए एक मार्गदर्शन।

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Ayush4958 , wherever you have kept MS and HS could you please replace them with above hindi full forms?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry for late reply
I will replace them by EOD

@Ayush4958
Ayush4958 force-pushed the translate-teacher-guide-in-hindi branch from 7b48432 to 8a93e5c Compare August 11, 2026 19:34
@Ayush4958

Copy link
Copy Markdown
Contributor Author

@Divyansh013
I had replace them,
take time for review

thanks ....

@Divyansh013

Copy link
Copy Markdown
Member

LGTM @Ayush4958

@Ayush4958

Ayush4958 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@Divyansh013
when I was working on this PR,
I had noticed that there are lot of pages which
don't have translation to hi lang

can we open a issue thread tracker for it and just mark pages as they get translated ??

@ritiupa

ritiupa commented Aug 14, 2026

Copy link
Copy Markdown

Thanks for taking this on, translating the whole teacher guide is a big contribution, and the input events / asset loading breakdown is clear and well organized.

I did a full read-through against the English source (structural comparison plus a written review). A few things I'd flag before merge:

Blockers

  1. The frontmatter still has featuredImageAlt: TODO BETTER IMAGE, a placeholder that shouldn't ship. Needs real alt text for the featured GIF.
  2. The compatibility add-on bullet links out to a private Google Doc (docs.google.com/document/d/1Dk5nqLYL_...) instead of a public resource. Looks like a leftover scratchpad link, worth confirming it wasn't meant to point somewhere public instead.
  3. The alt text on the version picker screenshot has a typo: "संकरणों" should be "संस्करणों" ("versions").

Phrasing worth a native speaker's call, not blockers

  • "सहेजना" for "save [the canvas]" leans toward preserving/cherishing rather than the functional save action. "सुरक्षित करना" or "सेव करना" reads closer to the intended meaning.
  • "इनपुट आयोजन" for "Input Events" (used throughout, including the section heading) reads as "input ceremony/organizing" rather than the programming sense of "event." "इनपुट इवेंट्स" or "इनपुट घटनाएँ" might fit better.
  • "संपत्तियाँ" for "assets" reads as financial assets/property rather than media files. "एसेट्स" or "मीडिया फ़ाइलें" might fit better.
  • "स्विच" (switching a sketch back to v1 in the editor) is the English word transliterated rather than translated. "बदल सकते हैं" would be more natural.
  • "और यह बिल्कुल वैसा व्यवहार नहीं करता है" overstates "doesn't behave quite the same": "बिल्कुल...नहीं" reads as "not at all," stronger than the English.
  • The sentence ending "...और p5.js v2 में पेश किए गए परिवर्तन।" is a dangling noun clause with no verb, reads incomplete.
  • "मैं जानता हूँ" in the opening paragraph is grammatically masculine voice. The byline is Adrienne Gifford, worth double-checking whether "जानती हूँ" was intended.
  • रेखाचित्र/स्केच and चित्र/छवियाँ are each used interchangeably for the same concept (sketches, images) in different spots, might be worth picking one per concept for consistency.
  • The frontmatter title uses "मार्गदर्शन" while the H1 uses "ट्रांजिशन गाइड" (mixing Hindi and transliterated English) for what should be the same phrase.

Happy to take another pass once the blockers are in. Thanks again for the work on this.

@ksen0

ksen0 commented Aug 14, 2026

Copy link
Copy Markdown
Member

@ritiupa thanks for checking! I'll make a PR against the English version (I'd suggest alt text of like "Animated diagram of API changes between v1 and v2 or p5.js") The gdoc link should be removed, I think it's already been fixed in english and Korean.

@Ayush4958 please feel free to include a translation of the alt text above, and exclude the link. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants