Repository navigation
Support PHPUnit 10+ and count assertions - #62
Merged
Merged
Conversation
Skip scenarios with Assert::markTestSkipped() instead of throwing PHPUnit\Framework\SkippedTestError, which was removed in PHPUnit 10. Make the see* steps use PHPUnit assertions so that Codeception counts them; previously only failures were recorded, so passing runs reported "Assertions: 0". Allow PHPUnit 10-12 and Psalm 7 in dev dependencies, run CI on ubuntu-latest with PHP up to 8.4, and adjust the fixtures for Psalm 7's purity checks. Claude-Session: https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW
The lowest allowed Psalm versions crash on PHP 8.4. Claude-Session: https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipped steps throw
PHPUnit\Framework\SkippedTestError, which no longer exists in PHPUnit 10+, and passing steps aren't counted as assertions.Before:
After:
https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW