Repository navigation
Fix build-system.requires cross-reference to dependency specifiers (#1644) - #2156
Open
paneendrakumar0 wants to merge 1 commit into
Open
paneendrakumar0 wants to merge 1 commit into
paneendrakumar0 wants to merge 1 commit into
Conversation
…ypa#1644) Signed-off-by: paneendrakumar0 <paneendra100@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
source/specifications/pyproject-toml.rst, the specification for the[build-system]table previously stated:In packaging standards, PEP 518 specifies that
build-system.requirescontains PEP 508 dependencies (package name + version constraint + markers, e.g.,"setuptools>=61.0","wheel"). These are dependency specifiers, not PEP 440 version specifiers (which solely define version comparison operators like>=61.0).This PR corrects the text and the Sphinx cross-reference to point to the dependency specifier specification (
dependency-specifiers.rst), matching PEP 518, the example given directly beneath it (requires = ["setuptools"]), and the rest of thepyproject.tomlspecification.Fixes #1644
Verification
sphinx-build -n -W source build(0 warnings, 0 errors).dependency-specifiers.html#dependency-specifiers.pre-commit run --all-filespasses all formatting and linting checks cleanly.📚 Documentation preview 📚: https://python-packaging-user-guide--2156.org.readthedocs.build/en/2156/