Repository navigation
Conversation
Delegate reversed addition through Time.__add__, preserving supported duration handling and subclass dispatch. Document both operand orders and add regressions. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 22:16
Merging this PR will not alter performance
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Fix
pendulum.time(12, 30) + timedelta(minutes=15)succeeds, but reversing the operands raisesTypeError. AddTime.__radd__delegating toself.__add__, asDateTimealready does. This preserves subclass dispatch and the existing handling of zero, microseconds, midnight rollover, unsupported types and day-containing durations.Eleven new cases cover native timedelta/Pendulum Duration, carry and rollover, rejected day components, exact result type and subclass overrides. Documentation shows both operand orders and the existing day restriction.
Validation
Linux/Python 3.12.14, unchanged project dependencies and pinned hooks:
The unchanged skips cover Windows-only behavior and upstream timezone-transition limits. Strict docs retain existing INFO-level anchor diagnostics; packaging retains an existing Cargo metadata warning. Other Python/OS combinations and hosted CI are not claimed passed.
Prepared and tested with AI assistance (OpenAI Codex); no human review is claimed.