Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 12, 2026 21:42
Merging this PR will not alter performance
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Summary
Addresses the duration-to-duration division and remainder part of #799.
duration(years=1) / duration(months=1)currently raisesZeroDivisionError: the conversion used by/,//,%, anddivmod()omits both operands' calendar components. Nonzero fixed components can instead hide the problem and produce incorrect quotients or remainders.Include the existing 365-day/year and 30-day/month approximations when these operations compare two durations. For example, one month divided by ten days is now
3.0, and one month modulo seven days is two days. Keep scalar arithmetic's separate calendar components unchanged. Intervals retain their actual elapsed time, andAbsoluteDurationretains its existing already-expanded storage representation.This does not include the float-multiplication issue in #975 or native
datetime.timedeltaoperand support in #1042.Validation
On Linux with CPython 3.12.14, against master
e06dacedc4cdea90fa1286b3965d180ab94cf251:The skips are one Windows-only test and two existing ZoneInfo POSIX-transition limitations. The hosted Python/OS matrix has not run on this change yet; no hosted pass is claimed.
Prepared and tested with OpenAI Codex assistance, including automated review. No human review is claimed.