Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the remaining
ParkingLot.broken_byitem from #3221: the initially empty list, call order, implicit current task, and repeated entries when a lot is broken more than once.The attribute is documented in the class's Google-style
Attributessection and excluded from automatic member enumeration to avoid a duplicate empty entry. Its missing-docstring exemption is removed. TheHasFileno.filenoitem remains separate and is already covered by #3523; this PR does not close the tracking issue.Validation:
pytest src/trio/_core/_tests/test_parking_lot.py -q: 11 passed. Existing tests cover repeated and explicit breaker tasks.sphinx-build -b html -W --keep-going docs/source docs/build/html: passed.ParkingLot.broken_byanchor with the explanation.git diff --checkpassed.Includes a documentation newsfragment. Runtime behavior is unchanged.
AI assistance: Codex helped prepare the documentation and perform the checks.