Repository navigation
Only react to the re-review phrase when changes were requested - #713
Open
muhammad-a-dev wants to merge 1 commit into
Open
muhammad-a-dev wants to merge 1 commit into
muhammad-a-dev wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #713 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2173 2181 +8
Branches 100 101 +1
=========================================
+ Hits 2173 2181 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #687.
Right now the bot answers "I have made the requested changes; please review again" on any PR, even when nobody requested changes. On python/cpython#144604 it replied three times, moved the PR to "awaiting change review" and pinged nobody.
This makes
new_comment()skip the trigger unless the PR has the "awaiting changes" label, which matches the flow in the README (only "Awaiting changes" moves to "Awaiting change review").Added a test for the no-changes-requested case and updated the existing trigger tests to start from "awaiting changes". Full test suite passes locally with 100% coverage.