gh-126253: Ignore unknown Windows file attribute bits in scandir test - #156305
Open
Wanbinyu wants to merge 1 commit into
Open
gh-126253: Ignore unknown Windows file attribute bits in scandir test#156305Wanbinyu wants to merge 1 commit into
Wanbinyu wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126253.
os.scandir().stat()andos.stat()can return different values forst_file_attributeswhen NTFS reports bits that are not exposed by Python'sstatmodule. Limit the scandir test comparison to the publicstat.FILE_ATTRIBUTE_*bits, while continuing to compare every public bit strictly.The regression test constructs
os.stat_resultvalues with the reported0x10000000bit so the behavior is covered even on Windows builds where the filesystem does not naturally return it. It also verifies that a difference inFILE_ATTRIBUTE_READONLYstill fails the comparison.Tests:
PCbuild\amd64\python_d.exe -m test test_os.test_os -m "*attributes*" -vPCbuild\amd64\python_d.exe -m test -v test_osPCbuild\amd64\python_d.exe Tools\patchcheck\patchcheck.pyThis contribution was prepared with assistance from OpenAI Codex. I reviewed and tested the resulting changes.
test_os.test_attributes()fails on Windows #126253