Repository navigation
Do not use types as error contexts during type checking - #22156
Open
ilevkivskyi wants to merge 2 commits into
Open
ilevkivskyi wants to merge 2 commits into
ilevkivskyi wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16175
Fixes #8592
Situations where an error has a wrong line number are very annoying (maybe even more than a crash). Using types as error context during type checking is really risky. So, I removed all such cases in
checker.pyincheckexpr.py(by locally removingContextas a base class forType). Most remaining uses are insemanal.pyandtypeanal.py. Those are less risky, and trickier to remove.Notes:
cc @JukkaL