PEP 843: Address comments - #5106
Merged
Merged
Conversation
NeilGirdhar
changed the title
Documentation build overview
|
NeilGirdhar
marked this pull request as draft
August 22, 2026 21:05
Contributor
Author
|
Hold on, I'm going to address Jorenham's comment |
NeilGirdhar
marked this pull request as ready for review
August 22, 2026 21:26
NeilGirdhar
marked this pull request as draft
August 22, 2026 21:28
NeilGirdhar
force-pushed
the
comments
branch
2 times, most recently
from
August 22, 2026 21:32
cf71515 to
846f982
Compare
NeilGirdhar
marked this pull request as ready for review
August 22, 2026 21:32
Member
|
Could you also include "DRY (don't repeat yourself)" for the first DRY mention in prose? |
Contributor
Author
|
@hugovk Good idea, will do |
- Consolidated the ``__all__``-normalization pseudocode into a single copy in `Specification`_, instead of repeating it three times. - Added an Open Issues section asking whether ``export`` should raise a ``DeprecationWarning`` on a non-list ``__all__``. - Cited the canonical definition of DRY. - Restricted ``export`` to module level.
Member
|
All ready here? |
Member
|
Also, again, please don't rewrite your commit history and force-push. It makes reviewing harder, and we squash this all into one commit when merging anyway. |
Contributor
Author
|
Yes, ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__all__-normalization pseudocode into a single copy inSpecification_, instead of repeating it three times.exportshould raise aDeprecationWarningon a non-list__all__.exportto module level.I also fixed the formatting to agree with PEP 12. (Sorry for the long diff.)