Fix nominee visibility during open elections - #3099
Draft
Parzival235 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The authenticated-user branch in
NomineeList.get_queryset()filtered only onNominee.userand did not filter by election. This returned nominations of the user across election cycles instead of nominations the user had made in the current election. Separately,Nominee.visible()did not consider the nominator, so a candidate linked from the corrected list still returned 404.Validation
DATABASE_URL=sqlite:///:memory: uv run --group dev python manage.py test apps.nominations.tests— 66 tests passedruff check apps/nominations/models.py apps/nominations/views.py apps/nominations/tests/test_views.pyruff format --check apps/nominations/models.py apps/nominations/views.py apps/nominations/tests/test_views.pyFixes #3094