Skip to content

[mmap] Allow None for mmap.flush in Python 3.14 #16284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Aug 22, 2026
+4 −5
Merged

[mmap] Allow None for mmap.flush in Python 3.14 #16284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions stdlib/@tests/stubtest_allowlists/py314.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ concurrent.interpreters._crossinterp.UNBOUND_REMOVE
# Condition functions are exported in __init__
threading.Condition.locked

# Starting with Python 3.14.1, these methods accept None for some of their
# parameters, but would raise a TypeError with Python 3.14.0.
mmap.mmap.flush

# ====================================
# Pre-existing errors from Python 3.13
# ====================================
Expand Down
5 changes: 4 additions & 1 deletion stdlib/mmap.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ class mmap:

def close(self) -> None: ...
if sys.version_info >= (3, 15):
def flush(self, offset: int = 0, size: int = ..., /, *, flags: int = 0) -> None: ...
def flush(self, offset: int = 0, size: int = -1, /, *, flags: int = 0) -> None: ...
elif sys.version_info >= (3, 14):
# size default changed in Python 3.14.1
def flush(self, offset: int = 0, size: int | None = None, /) -> None: ...
else:
def flush(self, offset: int = 0, size: int = ..., /) -> None: ...

Expand Down