Skip to content

[ET-VK][binary] Nest binary operator sources - #23491

Open
SS-JIA wants to merge 4 commits into
gh/SS-JIA/658/basefrom
gh/SS-JIA/658/head
Open

SS-JIA wants to merge 4 commits into
gh/SS-JIA/658/basefrom
gh/SS-JIA/658/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Ulterior Motive

Organize Vulkan operators by implementation family so operators with multiple routes can use clear, scalable directory layouts.

Rationale

What: Move standard binary GLSL, YAML, shared shader definitions, and C++ implementations into dedicated binary/ directories.

Why: The flat shader and implementation directories obscure ownership as operator families grow. Binary operators provide a contained validation of nested-source support before reorganizing larger families such as convolution.

Details

  • Move tensor-tensor and tensor-scalar shader templates, YAML variant definitions, and binary_op_defs.glslh under glsl/binary/, and q8ta_binary under glsl/binary/q8ta/.
  • Move BinaryOp.cpp and BinaryScalarOp.cpp under impl/binary/, and the quantized Q8taBinary.{h,cpp} under impl/binary/q8ta/.
  • Update shader-name validation to address path-qualified template identities, the Q8taBinary.h include in TestQ8taBinary.cpp, and the binary section labels in op_registry.py.
  • Moved files are recorded as renames.
  • Preserve generated shader names and runtime dispatch behavior.

Differential Revision: D123101915

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23491

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1fbfcf9 with merge base bdb489e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]

This branch was successfully deployed

1 active deployment
cadence — 1fbfcf9a Deployed Oct 10, 2026 by SS-JIA via hifi-op-test / hifi4 #32854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant