Repository navigation
Do not delegate CoreML reflect/replicate pads beyond the last two dims - #23687
hemanth1999k wants to merge 1 commit into
Conversation
Core ML only supports reflect and replicate padding on the last two dimensions. ReflectionPad3d, ReplicationPad3d, or a reflect pad of just the depth dimension of a 5D input lowered fine, then failed to load: Padding for more than two dimensions only supports `constant` mode The partitioner now overrides support for those pads, so ops_to_not_decompose no longer keeps them whole. They decompose into ops Core ML runs, and the model stays delegated and matches eager. Fixes pytorch#11708 Fixes pytorch#11709
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23687
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Hi @hemanth1999k! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
|
@pytorchbot label "release notes: apple" |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Core ML only supports
reflectandreplicatepadding on the last two dimensions.ReflectionPad3d,ReplicationPad3d, or a reflect pad of only the depth dimension of a 5D input currently lower to Core ML without complaint, then fail when the program loads:CoreMLPartitionernow overrides support for these pads (aten.padin reflect/replicate mode with a nonzero pad outside the last two dims, plusreflection_pad3d/replication_pad3d).ops_to_not_decomposetherefore stops keeping them whole, they decompose into ops Core ML runs, and the model stays delegated and matches eager. 1D/2D reflect and replicate pads and constant pads are unchanged.Fixes #11708
Fixes #11709
Test plan
Added
test_nonconstant_pad_beyond_last_two_dims_is_decomposedtobackends/apple/coreml/test/test_coreml_partitioner.py. It coversReflectionPad3d,ReplicationPad3d, and a depth-only reflect pad. For each it checks thataten.pad.defaultis not inops_to_not_decompose, lowers withto_edge_transform_and_lower, runs the program throughexecutorch.runtime.Runtime, and compares with eager (atol/rtol 1e-2 because Core ML computes in fp16). It also checks that a 2D reflect pad is still kept whole.13/13 pass with the change; on main only the new test fails. Run on macOS 26.2, executorch 1.5.1 / main, torch 2.14.0, coremltools 9.0.
ufmtandflake8are clean.Circular 3D pads still raise a ValueError at lowering, as they do on main; that is a separate issue and out of scope here.
cc @nil-is-all