Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23690
Note: Links to docs will display an error until the docs builds have been completed.
|
Contributor
Author
|
@pytorchbot label "release notes: devtools" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display_or_print_dfstyles the dataframe withdf.style.applymap(...).Styler.applymapwas deprecated in pandas 2.1 and removed in pandas 3.0, so with pandas 3 that line raises an AttributeError. The bareexceptaround it swallows the error and falls back to the plain-text tabulate print, so in a notebookprint_data_tabular()silently stops showing the styled table, no error anywhere.The fix is just
applymap->map.Styler.mapexists since pandas 2.1 and the repo already needs pandas>=2.2.2, so nothing else changes.Test plan
Added test_display_or_print_df_in_ipython in devtools/inspector/tests/inspector_utils_test.py. It fakes the IPython modules, turns FutureWarning into an error (so it also catches the deprecated call on pandas 2.x), and checks the styled table goes to display() and nothing is printed. It fails on main and passes with the fix on pandas 3.0.6, and the rest of inspector_utils_test.py passes (93 tests). ufmt and flake8 are clean with the versions in requirements-lintrunner.txt.
cc @nil-is-all