Cover react/renderer/uimanager/consistency:consistency with Stable API guards - #58047
Open
j-piasecki wants to merge 2 commits into
Open
Cover react/renderer/uimanager/consistency:consistency with Stable API guards#58047j-piasecki wants to merge 2 commits into
react/renderer/uimanager/consistency:consistency with Stable API guards#58047j-piasecki wants to merge 2 commits into
Conversation
Summary: Classifies `react/renderer/consistency:consistency` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both headers in the module and declares the guard dependency in BUCK, CMake and the podspec. The private headers were reachable from higher tiers: `ShadowTreeRevisionConsistencyManager.h` was included by the for-frameworks `RuntimeScheduler.h` (and its two forks) and by the public `UIManager.h`, which would make the guard a hard error for consumers under `RN_STRICT_API`. Every use is a pointer, so those headers now forward declare the type and the include moves to `UIManager.cpp`. `UIManager.h` also drops `LazyShadowTreeRevisionConsistencyManager.h`, which re-exposed the same header through inheritance. Changelog: [Internal] Differential Revision: D116601683
…API guards Summary: Classifies `react/renderer/uimanager/consistency:consistency` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both headers in the module and declares the guard dependency in BUCK and CMake. The module is a `React-Fabric` subspec, so the CocoaPods dependency is already on the parent spec. The private headers were reachable from a higher tier: `ShadowTreeRevisionProvider.h` was included by `UIManager.h`, which is public, and that would make the guard a hard error for consumers under `RN_STRICT_API`. Every use is a pointer, so `UIManager.h` now forward declares the type and the include moves to the four source files that dereference it: `UIManager.cpp`, `UIManagerBinding.cpp`, `ViewTransitionModule.cpp` and `NativeDOM.cpp`. Changelog: [Internal] Differential Revision: D116920012
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116920012. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/uimanager/consistency:consistencyas a private target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/PrivateGuard.h>to both headers in the module and declares the guard dependency in BUCK and CMake. The module is aReact-Fabricsubspec, so the CocoaPods dependency is already on the parent spec.The private headers were reachable from a higher tier:
ShadowTreeRevisionProvider.hwas included byUIManager.h, which is public, and that would make the guard a hard error for consumers underRN_STRICT_API. Every use is a pointer, soUIManager.hnow forward declares the type and the include moves to the four source files that dereference it:UIManager.cpp,UIManagerBinding.cpp,ViewTransitionModule.cppandNativeDOM.cpp.Changelog: [Internal]
Differential Revision: D116920012