Drop unused Hermes import from RCTAppSetupUtils - #58056
Open
j-piasecki wants to merge 1 commit into
Open
Conversation
Summary: `RCTAppSetupUtils.h` imports `<reacthermes/HermesExecutorFactory.h>` but names nothing from it, so the import and the conditional that wrapped only it are removed. This unblocks classifying the Hermes executor as a private target under the three-tier C++ stable API visibility model, which it cannot be while a public header reaches it. Code that relied on reaching `HermesExecutorFactory` through this header should import it directly. Changelog: [iOS][Changed] - `RCTAppSetupUtils.h` no longer transitively imports `HermesExecutorFactory.h` Differential Revision: D116934198
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116934198. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTAppSetupUtils.himports<reacthermes/HermesExecutorFactory.h>but names nothing from it, so the import and the conditional that wrapped only it are removed. This unblocks classifying the Hermes executor as a private target under the three-tier C++ stable API visibility model, which it cannot be while a public header reaches it. Code that relied on reachingHermesExecutorFactorythrough this header should import it directly.Changelog:
[iOS][Changed] -
RCTAppSetupUtils.hno longer transitively importsHermesExecutorFactory.hDifferential Revision: D116934198