Repository navigation
Conversation
DevServerHelper opened and closed the packager connection in separate AsyncTasks on THREAD_POOL_EXECUTOR. A close could run before a pending open, and repeated opens could create two clients. Changing the bundle location from the dev menu also kept the old connection. In both cases, the old dev server could still reload the app. - Run openPackagerConnection and closePackagerConnection as tasks on one single-threaded executor. Tasks run in call order, off the UI thread, and only that thread uses packagerClient. The executor names its thread ReactPackagerConnection and stops it after 30 seconds without work. - Remember the host of the open client. If an open finds a client for a different host, close it and connect to the new host. - Check clientId on the caller's thread. A failed init() still crashes the app, as before; packagerClient stays null, so a later open can retry. - Change Bundle Location: close the packager connection before the reload, as setBundleSource does. Trim the input, then reject a host that OkHttp cannot parse in the connection URL and show a toast. Before, an invalid host was saved without a check. - ReconnectingWebSocket: change close state under the socket's monitor, so no message handler starts after closeQuietly() returns. Close a socket whose handshake finishes after closeQuietly() instead of reporting it as connected. - Add DevServerHelperTest, ReconnectingWebSocketTest and DevSupportHttpClientTest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, with two Metro servers running, an app that switches from one to the other (via Change Bundle Location,
setBundleSource, or a dev client) can keep its packager connection to the first. Pressingrin the first Metro's terminal then still reloads the app. I hit this while working in several worktrees at once, with several emulators, killing and restarting Metro servers. There it depends on timing. Change Bundle Location in the dev menu should reproduce it every time, because it never closed the old connection.DevServerHelperran open and close in separateAsyncTasks, so a close could overtake an open, and repeated opens could leak a client. Change Bundle Location never closed the old connection.ReconnectingWebSocketalso kept a socket whose handshake finished aftercloseQuietly().Changes:
ReconnectingWebSocketcloses a socket that opens aftercloseQuietly().Notes: open and close are now asynchronous, and
customCommandHandlers()handlers must not block.Changelog:
[ANDROID] [FIXED] - Fix the app staying connected to the previous Metro server after switching to another one
Test Plan:
New tests in
DevServerHelperTest,ReconnectingWebSocketTestandDevSupportHttpClientTest, plus the existingJSPackagerClientTest, all pass.