Repository navigation
[Reproducer] Text drops its last line when its box crosses y = 2048 on a 3x iOS screen (#58970) - #58972
Draft
ybelakov wants to merge 1 commit into
Draft
[Reproducer] Text drops its last line when its box crosses y = 2048 on a 3x iOS screen (#58970)#58972ybelakov wants to merge 1 commit into
ybelakov wants to merge 1 commit into
Conversation
…n a 3x iOS screen Reproducer for react#58970, not for merging: a grid of two-line Texts positioned absolutely around y = 2048. The ones crossing 2048 on a fraction get a 43.9998779296875pt box from Yoga and TextKit lays out only their first line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproducer for #58970, not for merging: it only replaces
RNTesterPlayground.js, as the issue template asks.A wrapped
<Text>whose box crosses y = 2048 in the scroll content draws one line short on a 3x iOS screen (New Architecture). Yoga'sroundLayoutResultsToPixelGridsubtracts the two rounded edges as floats; with the top below 2048 and the bottom above, the height comes out one float step short (43.9998779296875instead of44for two lines oflineHeight: 22).RCTParagraphComponentViewhands that box to TextKit as the container size, the second line "doesn't fit", and the text is laid out in the container's clip mode as one line. Fix for the Yoga half: react/yoga#2037.Changelog:
[INTERNAL] - Reproducer for #58970, not for merging.
Test plan
Open the Playground example in RNTester on a 3x iOS simulator or device (iPhone 16 Pro). It renders 12 two-line texts positioned absolutely around y = 2048 and scrolls to them.