Repository navigation
Cancel pending Fabric surface starts - #58977
Open
Abbondanzo wants to merge 1 commit into
Open
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: Surface startup is deferred to the main queue. A stop request that arrived before the deferred work previously returned without cancelling it, allowing the surface to start after its owner began tearing down. Track pending starts under the surface mutex so stop can cancel them before registration and startup. Keep attachment and startup serialized, and notify stage changes after releasing the mutex. Changelog: [iOS][Fixed] - Prevent Fabric surfaces from starting after an earlier stop request Differential Revision: D124262921
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124262921. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Surface startup is deferred to the main queue. A stop request that arrived before the deferred work previously returned without cancelling it, allowing the surface to start after its owner began tearing down.
Track pending starts under the surface mutex so stop can cancel them before registration and startup. Keep attachment and startup serialized, and notify stage changes after releasing the mutex.
Changelog:
[iOS][Fixed] - Prevent Fabric surfaces from starting after an earlier stop request
Differential Revision: D124262921