Repository navigation
fix: make community navigation accessible on mobile - #1445
fhammerschmidt wants to merge 6 commits into
Conversation
Add a mobile community navigation dialog with keyboard dismissal, focus restoration, and dismissal after navigation or resizing. Keep the desktop sidebar and cover mobile interactions with browser tests. Fixes #1411
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
guide | 29cf766 | Commit Preview URL Branch Preview URL |
Oct 11 2026, 10:11 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f098ed965
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The shared navigation callback now runs for page links. Keep the in-page docs sidebar static because the mobile drawer is provided by NavbarTertiary, and cover desktop navigation followed by resizing in a browser test.
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
Updated from the GitHub Actions visual baseline workflow.
The screenshot workflow updated the approved mobile community baseline. Trigger fresh PR checks from the verified branch head because the bot-triggered runs require approval. Fixes #1411
Pass the route from CommunityLayout and key the mobile menu by it so navigation resets local state. Mount the dialog only while open and use a stable React 19 callback ref for native setup and cleanup, removing all four effects. Cover StrictMode, focus restoration, rerenders, and navigation outside the drawer.
Make SidebarNav explicitly desktop-only by removing isOpen, toggle, and its unused mobile close button. Update both layouts and make category click callbacks optional so static navigation needs no placeholder handlers.
This branch was successfully deployed
1 participant
Community pages hide their sidebar on phones without providing a way to open it. Add a visible Community navigation button and a native modal drawer that reuses the existing categories and table of contents.
The drawer supports Escape dismissal and focus restoration, closes after page or section navigation (including the current page link), and dismisses when switching to desktop width. Page links now invoke the sidebar's navigation callback. SidebarNav now serves desktop navigation only: remove its obsolete isOpen and toggle props, mobile overlay styles, and close button. Both layouts use it without placeholder state or handlers. Documentation routes already provide their own mobile drawer through NavbarTertiary.
CommunityLayout passes the current route to the mobile menu and keys it by pathname, so navigation resets its local state. The dialog mounts only while open. A stable React 19 callback ref opens the native dialog and manages its close and breakpoint listeners, with cleanup on unmount. This requires no effects.
Validation:
Community phone preview
Website
masteronly; no compiler changes.Fixes #1411