Repository navigation
fix: remove stale configuration and honor deployment environment - #1450
fhammerschmidt wants to merge 2 commits into
Conversation
Honor manual preview and production selection in the docs deployment and its audits. Always pass an explicit Pages branch, including master for production, and cover the event/branch combinations in the workflow tests. Remove obsolete ignore and formatter entries, fix the compiler-bundle attribute path, and mark Makefile build and dev targets as phony. Keep index_data rules with their extractor until the separate dead-code cleanup removes both.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
guide | 9dc6f89 | Commit Preview URL Branch Preview URL |
Oct 11 2026, 11:37 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8546631dca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
Include the effective environment when manual deployments differ from the branch default. Preserve existing production-master and branch-preview artifact keys, and keep PR comparisons pointed at their target branch baseline.
This branch was successfully deployed
1 participant
Manual docs deployments ignored the selected environment, and production passed an empty Pages branch. Honor the choice throughout deployment, Lighthouse, and E2E checks, and remove configuration left over from earlier tooling.
Fixes #1418. Part of #1421.
--branch=master; manual previews of master use a preview alias. Existing PR preview aliases stay stable. This follows Pages' branch-based environment selection.apps/docs/public/playground-bundles/. Remove obsolete Next.js/Vercel, dist, MDX manifest, compiled.mjs, temporary-file formatter, and redundant ignore entries. Keep current JSX, build, script-bundle, and browser-compiler output ignored.buildanddevtargets as phony so matching files or directories cannot skip their recipes.Branch:
fix/1421-stale-config, based on websitemaster(v12), pushed directly torescript-lang/rescript-lang.org. No compiler repository changes.Validation: strict ReScript compilation, Oxfmt and ReScript formatting checks, all 31 Lighthouse report tests, Bash syntax, all seven deployment event/branch/environment cases run directly (including baseline selection for non-PR runs), workflow YAML/input wiring, Git attribute/ignore checks, and a Make dry run with colliding build/dev directories pass locally. All six PR CI jobs pass on the final commit, including all 32 Lighthouse workflow tests and 31 report tests. The workflow suite cannot spawn Bash locally (
EPERM, also after an unrestricted retry); its regression coverage is verified in CI.Related cleanup: the Yarn release ignore pattern is identical to #1449. Keep the
index_datarules until #1443 removes their obsolete extractor and the rules together. The Makefile stays as a small wrapper around existing Yarn commands.