Repository navigation
Move JsxDOM types etc. into @rescript/react(-dom) #8400
Description
Proposal:
- Remove modules
Dom,Dom_storage,Dom_storage2from the@rescript/runtimepackage - Instead of those, vendor the base package of
experimental-webapi - Make the vendored
@rescript/reactdepend on that - Split off
@rescript/react-dom - Move
JsxDOM/JsxDOMStyle/JsxEventinto@rescript/react-dom - Make everything work 🙂
- Also make it work/test with rescript-react-native and a with non-React JSX runtime like Xote
Note that any vendoring here (@rescript/react, @rescript/react-dom, relevant parts of webapi and rescript-react-native/Xote) does not mean moving the source of truth for these packages into the compiler repo. It's just for easier and quicker iteration while moving things around.
Once the new shape has crystallized, things need to be synced back to the respective repos.
Activity
dkirchhof commentedon Apr 30, 2026
I started to work on it here:
rescript-lang/rescript-react#151
#8282
Now, after about 2 months, there are a lot of conflicts. Maybe it's a good starting point. Maybe not. Could fix the merge conflicts first, if this is going in the right direction.
tsnobip commentedon Apr 30, 2026
@cknitt do we want to split off @rescript/react-dom to its own package or should we rather use rewatch "features"?
cknitt commentedon Apr 30, 2026
Not sure. I was originally leaning towards splitting it off to match what people would be expecting following the npm package structure (
react/react-dom,@types/react/@types/react-dom).OTOH maybe keeping it a single package with all features on by default would improve compatibility/ease migration.
tsnobip commentedon May 1, 2026
You're right, those are separate packages in js so it'd make sense to stick to the same structure.
dkirchhof commentedon May 14, 2026
So, I updated my branches and fixed the conflicts.
Unfortunately, I have no idea how to fix the missing dependencies. Rescript-React should be included in the monorepo since the dependencies point to a "workspace" version?!