Repository navigation
Remove OCaml leftovers - #8805
Conversation
Drop their descriptions, letter mappings and mentions in the default warning settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1 Signed-off-by: Christoph Knittel <ck@cca.io>
Every match on it was `assert false`. Removing it changes the binary layout of type declarations, so bump the .cmi and .cmt magic numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1 Signed-off-by: Christoph Knittel <ck@cca.io>
It is the pre-res name of res.braces and nothing produces it anymore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1 Signed-off-by: Christoph Knittel <ck@cca.io>
Const.int32/int64/char/float, the attr helpers and Te.decl/rebind came from OCaml and have no callers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1 Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1 Signed-off-by: Christoph Knittel <ck@cca.io>
|
@codex review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8805 +/- ##
==========================================
+ Coverage 80.38% 80.40% +0.02%
==========================================
Files 447 447
Lines 60999 60984 -15
==========================================
+ Hits 49034 49036 +2
+ Misses 11965 11948 -17
🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8805 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bff2f4bdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Removes OCaml leftovers that ReScript code can't produce or reach. Each commit removes one:
-warn-helpdescriptions still listed warnings 17, 18, 19, 25, 31, 36, 46, 55 and 59, which have no constructor anymore. The warning letters (c,k,l,m,s,v,x) and the defaults still pointed at removed numbers too: the default-wdisabled 50, and the default-warn-errorenabled 6. These are dropped from the descriptions, the letters, the defaults, the build schema,ERROR_VARIANTS.mdand the dev playground's flags. No warning that can fire changes.Record_float_unused. This record representation was OCaml's float-only record. It is never created, and every match on it wasassert false. It wasn't the last constructor ofrecord_representation, so removing it changes the binary layout of type declarations, and the.cmiand.cmtmagic numbers are bumped.ns.bracesattribute name. It is the pre-resname ofres.braces. The v0 bridge still decoded it in PPX output, but nothing has produced it since the attribute was renamed.Ast_helperfunctions.Const.int32/int64/char/float,Typ/Pat/Exp/Mty/Mod.attrandTe.decl/rebindhave no callers.User-facing OCaml leftovers stay out of this PR: the
linteger suffix, the predefinedEnd_of_fileexception and theocaml.*attribute aliases. Doc attributes users can write (@ocaml.doc,@ns.doc) are also unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_013ZYFYMu3AE9P1xFVCR34d1