Repository navigation
Alpha and beta releases sort above the final release #58
Description
Activity
- added a commit that references this issue
on Oct 9, 2026 One more consequence of the same
comparisonVersionString()logic: lower-case-rctags are left untouched while-betais rewritten into extra numeric parts, sov3.5.0-beta.1also ranks abovev3.5.0-rc.1. With--stability=betaand both pre-releases published,rr getinstalls the older beta instead of the RC.The acceptance tests in #66 cover it in
VersionSelectionTest::prefersReleaseCandidateOverOlderBeta(skipped with a reference here). The lower-case--stability=rcpart of that test is #67.
Description
ReleasesCollection::sortByVersion()ranks alpha and beta pre-releases above the final release of the same version. Sortingv2024.1.0-alpha.1,v2024.1.0,v2024.1.0-beta.1,v2024.1.0-rc.1gives:Expected:
v2024.1.0,v2024.1.0-rc.1,v2024.1.0-beta.1,v2024.1.0-alpha.1.get-binaryanddownload-protoc-binaryinstall the first release of the sorted list that passes the stability filter. With--stability=beta(or lower) they pick the beta over the final release that is already out.comparisonVersionString()replaces-<stability>with.<weight>..v2024.1.0-beta.1therefore compares asv2024.1.0.2..1, andversion_compare()ranks it abovev2024.1.0because it has more numeric parts. Lower-case-rctags are left untouched (the stability isRC), so they happen to sort correctly. Upper-case-RCtags have the same problem as beta and alpha. #2 was about the order among pre-releases.Steps to reproduce
#[Skip]fromReleasesCollectionTest::sortByVersionPutsPreReleasesBelowFinalRelease.vendor/bin/testo --filter=sortByVersionPutsPreReleasesBelowFinalRelease.Additional context
The release lookup may be replaced by DLoad in #49, in which case this code goes away.