Repository navigation
refactor: add #[\Override] and drop the psalm baseline - #64
Merged
Merged
Conversation
refactor: resolve the Psalm baseline in code ci: drop the psalm baseline and the MissingOverrideAttribute suppression The baseline entries are fixed with accurate docblocks, strict comparisons and typed option reads, without signature changes. Two suppressions stay: ClassMustBeFinal, since making public classes final would break BC, and the undefined $config in GetBinaryCommand::installConfig(), tracked in #62. Collection suppresses UnsafeGenericInstantiation because its constructor and all subclasses are final. Assisted-By: Claude Opus 5.5
ci: run psalm on pushes to 2.x with a read-only token The previous commit only removed psalm-baseline.xml; this one carries the code and config changes it describes. Assisted-By: Claude Opus 5.5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (61)
💤 Files with no reviewable changes (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis PR updates Psalm CI and configuration, removes the Psalm baseline, adds override attributes and type documentation across CLI, configuration, archive, and repository code, and adjusts checks for empty values, temporary directories, and extracted files. ChangesPsalm and PHP typing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete regression is established in the reviewed changes, so the PR's merge risk is minimal, subject to normal CI checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 126 functions across 50 files. (8 skipped… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely summarizes the main changes: adding #[\Override] attributes and removing the Psalm baseline. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 126 functions across 50 files. (8 skipped: 2 unsupported, 6 over the file limit.)
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
#[\Override], and Psalm'sMissingOverrideAttributesuppression is gone.psalm-baseline.xmlis removed. Its 46 entries are fixed in code without signature changes: accurate docblocks (collections, GitHub API shapes, stability, config sections), strict comparisons instead of truthy checks, and typed reads of console options. Psalm is green at level 1 without a baseline.2.xwith a read-only token.Review notes
ClassMustBeFinalstays suppressed: making the public classes final would break BC for users who extend them.$configinGetBinaryCommand::installConfig()has an inline suppression pointing to .phar assets cannot be opened, and a failed config generation still writes .rr.yaml #62, so it is not fixed here.CollectionsuppressesUnsafeGenericInstantiation: its constructor and every subclass are final, sonew staticcannot break the item type.--presetoption and an emptyGITHUB_TOKEN/temp directory are now checked againstnull/''instead of truthiness. The only value treated differently is the string"0".Checklist
Summary by CodeRabbit
nullor an empty string are validated as directory paths.