Skip to content

Update dependencies - #1279

Open
0xfornax wants to merge 12 commits into
masterfrom
update-dependencies
Open

0xfornax wants to merge 12 commits into
masterfrom
update-dependencies

Conversation

@0xfornax

@0xfornax 0xfornax commented Oct 9, 2026

Copy link
Copy Markdown
Member

Updates:
• Go 1.27.2
• go-ethereum 1.17.8, ProtonMail go-crypto 1.5.2 (adding a signature verification test), prometheus/client_golang 1.25.0, golang.org/x/sync 0.24.0, and golang.org/x/net 0.60.0.
• Docker client moves from github.com/docker/docker to moby/client
• Alertmanager v0.34.1, Grafana 13.2.3, Alpine 3.24.2, and the curl fallback image 8.22.0.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Coverage Report

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/update/assets 4.68% (+4.68%) 👍
github.com/rocket-pool/smartnode/rocketpool/node 0.48% (+0.03%) 👍
github.com/rocket-pool/smartnode/rocketpool/validator 2.13% (+2.13%) 👍
github.com/rocket-pool/smartnode/shared/services 0.97% (-0.17%) 👎
github.com/rocket-pool/smartnode/shared/services/rocketpool 0.44% (-0.03%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/node/check-megapool-exit-requests.go 0.00% (ø) 6648 (-576) 0 6648 (-576)
github.com/rocket-pool/smartnode/rocketpool/node/check-minipool-exit-requests.go 0.00% (ø) 6675 (-1322) 0 6675 (-1322)
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-exit.go 0.00% (ø) 3460 (-685) 0 3460 (-685)
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-performance.go 0.38% (-0.00%) 4519 (+18) 17 4502 (+18) 👎
github.com/rocket-pool/smartnode/rocketpool/node/distribute-minipools.go 0.00% (ø) 3459 (-514) 0 3459 (-514)
github.com/rocket-pool/smartnode/rocketpool/node/download-reward-trees.go 0.00% (ø) 1626 (-110) 0 1626 (-110)
github.com/rocket-pool/smartnode/rocketpool/node/manage-fee-recipient.go 2.18% (+0.06%) 2473 (-540) 54 (-10) 2419 (-530) 👍
github.com/rocket-pool/smartnode/rocketpool/node/notify-final-balance.go 0.00% (ø) 3805 (-698) 0 3805 (-698)
github.com/rocket-pool/smartnode/rocketpool/node/notify-validator-exit.go 0.00% (ø) 3671 (-1012) 0 3671 (-1012)
github.com/rocket-pool/smartnode/rocketpool/node/prestake-megapool-validator.go 0.00% (ø) 2542 (-672) 0 2542 (-672)
github.com/rocket-pool/smartnode/rocketpool/node/provision-express-tickets.go 0.00% (ø) 2189 (-420) 0 2189 (-420)
github.com/rocket-pool/smartnode/rocketpool/node/set-latest-delegate.go 0.00% (ø) 3034 (-712) 0 3034 (-712)
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 3599 (-846) 0 3599 (-846)
github.com/rocket-pool/smartnode/rocketpool/validator/fee-recipient.go 3.71% (+3.71%) 2746 (-59) 102 (+102) 2644 (-161) 👍
github.com/rocket-pool/smartnode/shared/services/rocketpool/client.go 0.38% (-0.03%) 26014 (-1428) 98 (-14) 25916 (-1414) 👎
github.com/rocket-pool/smartnode/shared/services/services.go 2.17% (-0.22%) 6326 (+256) 137 (-8) 6189 (+264) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/rocketpool-cli/update/assets/keyring_test.go
  • github.com/rocket-pool/smartnode/rocketpool/validator/fee-recipient_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant