Repository navigation
fix(vscode): show an unconfigured Rstack lint config as not detected - #95
Merged
Merged
Conversation
Follow-up to #94 (#93). A bridged lint runtime whose root rstack.config.* has no define.lint() reported `running` with a detail, which the status bar hover rendered as a green check beside Rslint with the reason only in the icon tooltip. The status bar's word for "this tool has no configuration here" is `not-detected`, so the `unconfigured` verdict now maps to `{ kind: 'not-detected', detail }` and the reason is shown as a hover notice row. - `StackState['not-detected']` gains an optional `detail`; only a runtime-level "nothing configured" verdict sets it, detection never does, so every other hover is unchanged. - The status bar spells out the `not-detected` detail; one shared `stackStateDetail` replaces the two identical switches in the shell and the lint fold. - `liveRslintStatus` / `reportLive` (renamed from `running*`) keep the advisory-wins precedence; the worker stays up, no poll, no toast. - Fold: an unconfigured-only folder stays `not-detected` with its reason; a healthy native runtime beside it wins. - AGENTS.md adaptation 7 and the lint-shim gotcha record the design, including that the verdict lives with the runtime (an idle folder reads `running: idle` until a document opens).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #94. A bridged lint runtime whose root
rstack.config.*has nodefine.lint()reportedrunningwith a detail. In the status bar hover that is a green check beside Rslint, with the reason visible only in the icon's native tooltip, so a formatting-only project looked like Rslint was linting it. The status bar's existing word for "this tool has no configuration here" isnot-detected, so theunconfiguredverdict now maps to it, and the reason is shown as a notice row under the hover table.What the user sees for a formatting-only project: hover Rstack in the status bar → the Rslint row shows the grey circle-slash icon, and one notice row reads
no define.lint() in rstack.config.ts. The item text stays$(zap) Rstack, the per-stack restart action is still offered, there is still no toast, nocrashed, no dependency poll, and oneinfoline in the Output channel. Every other hover is unchanged: detection's ownnot-detectedcarries no detail and therefore adds no notice row.Fold rules, written as comments in
stacks/lint/status.ts:not-detectedwith its detail (not masked intorunning: idle).running): the folder is linting. The same rank applies across folders in multi-root.The worker stays alive underneath
not-detected, which is the reverse of howrunning: idledecouples state from process.packages/vscode/AGENTS.mdadaptation 7 and the lint-shim gotcha are updated accordingly.Evidence
pnpm lint✓ ·pnpm fmt:check✓ ·pnpm test:unit370 passed, 0 failed.VSCODE_CLI=1:Rstack fmt-only config,Missing config dependency,Rstack lint bridge,JS config testsallExit code: 0. The fmt-only suite now waits forkind === 'not-detected'with adefine.lint()detail on both the folder and the runtime state, then addsdefine.lint()and asserts plainrunningplus theno-debuggerdiagnostic from the same worker pid.runningshape it fails withTimed out waiting for the unconfigured not-detected detail, so the assertion is live.define.fmt()-only project (rstack 0.8.2): hover shows the Rslint row with the circle-slash icon and the noticeno define.lint() in rstack.config.ts; the Output channel logsRslint status: not detected — no define.lint() in rstack.config.ts.Merge Danger
Door: two-way
Revert restores the
running+ detail shape from #94. No settings, protocol versions or published surfaces change; thenot-detecteddetail is editor-internal state.Blast Radius: status bar + lint-bridged
StackState['not-detected']gains an optional field, read only by the status bar's notice rendering and lint's fold helpers. Only bridged lint runtimes whose shim refuses produce it; fmt, Rstest and native Rslint runtimes never set it.Related Links
Checklist