Repository navigation
Re-enable TestIO_Console#test_intr on FreeBSD - #168
Merged
Merged
Conversation
Ran 90 times on each of the rubyci FreeBSD 14.5 amd64 and 15.1 arm64 machines, in isolation and with the whole file both serially and under -j2, with no failure. ruby/ruby@3c7eab4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestIO_Console#test_intrhas been omitted on FreeBSD since 2022 because of a randomTimeout::Erroron FreeBSD 13. I ran it 90 times on each of the rubyci FreeBSD 14.5 amd64 and 15.1 arm64 machines, in isolation and with the whole file both serially and under-j2, and it never failed.The guard was already removed in ruby/ruby by ruby/ruby#18741. This forward-ports that change, so the file becomes byte-identical to ruby/ruby master and the sync produces no diff.
I left the FreeBSD
trap(:TTOU, 'IGNORE')inset_winsize_setupas is because I have not verified it yet.Generated with Claude Code