Skip to content

ssl: do not rescue Errno::EAGAIN #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhenium merged 1 commit into from
Oct 13, 2026
Merged

ssl: do not rescue Errno::EAGAIN #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions lib/openssl/buffering.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ def initialize(*)
def fill_rbuff
begin
@rbuffer.append_as_bytes(self.sysread(BLOCK_SIZE))
rescue Errno::EAGAIN
retry
rescue EOFError
@eof = true
end
Expand Down Expand Up @@ -152,11 +150,7 @@ def readpartial(maxlen, buf=nil)
end
end
if @rbuffer.empty?
begin
return sysread(maxlen, buf)
rescue Errno::EAGAIN
retry
end
return sysread(maxlen, buf)
end
ret = consume_rbuff(maxlen)
if buf
Expand Down Expand Up @@ -356,17 +350,13 @@ def do_write(s)
nwrote = 0
begin
while nwrote < buffer_size do
begin
chunk = if nwrote > 0
@wbuffer.byteslice(nwrote, @wbuffer.bytesize)
else
@wbuffer
end

nwrote += syswrite(chunk)
rescue Errno::EAGAIN
retry
chunk = if nwrote > 0
@wbuffer.byteslice(nwrote, @wbuffer.bytesize)
else
@wbuffer
end

nwrote += syswrite(chunk)
end
ensure
if nwrote < @wbuffer.bytesize
Expand Down
Loading