Repository navigation
Fix benchmarks that fail on Windows - #545
Merged
Merged
Conversation
Bundler's :ruby platform excludes Windows, so activerecord, railsbench and sequel had no sqlite3 there. The lockfiles stay valid, which I checked with a frozen bundle install on Linux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same as railsbench. Without zoneinfo files, booting the app fails in TZInfo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rubyboy reads its ROM with mode "r", so the CRLF conversion of Windows corrupts it and the emulator hits an unknown opcode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shipit-engine requires pty, which Windows lacks, at load time. Only deploy commands use it, and the benchmark never runs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Windows has no /dev/zero. The benchmark is about GVL handoffs rather than I/O, so a regular file of the same zeros is enough, and it is kept in the ignored data/ directory rather than left in a temporary directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the mswin-specific follow-up to #543. With it,
activerecord,railsbench,sequel,lobsters,rubyboy,shipitandgvl_release_acquirerun on mswin. Every change applies only on Windows, and the lockfiles still install frozen on Linux.sqlite3on:windowsas well inactiverecord,railsbenchandsequel, since Bundler's:rubyplatform excludes Windowstzinfo-datainlobstersasrailsbenchalready does, since Windows has no zoneinforubyboyROM with"rb"instead of"r", whose newline conversion corrupts itptyinshipit, whichshipit-engineuses only for deploy commands the benchmark never runsgvl_release_acquirefrom a regular file under the ignoreddata/instead of/dev/zeroOn Windows,
gvl_release_acquirereads a regular file instead of a device, so it should be left out of comparisons with Linux. Comparing two builds on the same machine is unaffected. I will send fixes forrubyboyandshipit-engineupstream separately, but running the benchmarks on mswin comes first, so this PR works around them for now.Generated with Claude Code