Repository navigation
Write hexapdf and lee output to Dir.tmpdir - #547
Merged
Merged
Conversation
On Windows /tmp is a directory at the root of the current drive, so both benchmarks fail with ENOENT unless someone has created it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hexapdfandleewrite their output files under a hard-coded/tmp. On Windows that path means\tmpat the root of the current drive, which usually does not exist, so both benchmarks fail withErrno::ENOENT.This writes the files to
Dir.tmpdirinstead, which is still/tmpon Linux unlessTMPDIRsays otherwise. Both benchmarks now finish with--onceunder the interpreter and YJIT on mswin and on Linux.Generated with Claude Code