Repository navigation
Fix follow-ups to the rb_len_t adoption - #229
Merged
Merged
Conversation
`len` is rb_len_t since d3c5e6d, so `%ld` no longer matches it once rb_len_t is wider than long. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d3c5e6d compared whence with Fixnums directly, so a Float or an object with `to_int`, which IO#seek and the JRuby version accept, raised Errno::EINVAL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`rake compile` builds the extension under `.build` since the switch to ruby-core-tasks, and only the `.so` and `Makefile` there were ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#228 left two issues behind.
StringIO#readstill formats itsrb_len_tlength with%ld, which stops matching oncerb_len_tis wider thanlong, as Feature #22400 proposes for mswin. It now usesPRIdLEN, with a fallback for Ruby withoutrb_len_t.StringIO#seekstarted comparing whence with Fixnums directly, so a Float or an object withto_intraisedErrno::EINVAL, whileIO#seekand the JRuby version accept them. This restores the conversion and adds a test.I also ignore
.build, whererake compilebuilds the extension since the switch to ruby-core-tasks.Generated with Claude Code