Repository navigation
CLDSRV-1022: remaining CVEs and dependency bumps - #6327
francoisferrand wants to merge 6 commits into
Conversation
The bookworm base carries a large backlog of OS CVEs that Debian has deferred or will not fix, including criticals in perl-base, zlib and sqlite. Node 24 on trixie-slim clears the criticals and most of that backlog; native modules build and load the same. Issue: CLDSRV-1022
python3-redis and python3-requests are only needed by the utapi v1 reindex scripts, which are run from the federation image. That image already ships Python for supervisord, so installing them there keeps Python and its CVEs out of the main image. Issue: CLDSRV-1022
@hapi/joi is deprecated and its advisory will not be fixed under that
name. joi 18 is already in the tree through arsenal, and the veeam
schemas were already requiring it without declaring it. The only visible
difference is the wording of range errors in config validation
("greater than" instead of "larger than").
Issue: CLDSRV-1022
utapi now validates its v2 API without oas-tools, which removes the deprecated request (with its old form-data, qs, tough-cookie and uuid) and jsonwebtoken 8 from our tree, and moves utapi from @hapi/joi to joi. The jsonwebtoken and request/form-data resolutions only existed for that chain and are dropped. Pinned on the pull request commit until it is released. Issue: CLDSRV-1022
c8 relies on V8's built-in coverage instead of instrumenting the code, which drops nyc's dependency tree (and its vulnerable uuid) and also follows the child processes started by yarn start. Config, scripts and the coverage image move over with the same include/exclude rules. Issue: CLDSRV-1022
mocha 11 pulls vulnerable serialize-javascript and diff, which only mocha 12 fixes. mocha-junit-reporter has not been updated for mocha 12's class-based reporters, so test reports now use mocha's built-in xunit reporter, through mocha-multi-reporters 1.5.2 which supports mocha 12. Reports are named after the yarn script instead of a content hash: it keeps runs sharing a directory or the artifacts folder apart, and makes the files easier to find. _mocha is gone in mocha 12, the debug scripts use mocha instead. Issue: CLDSRV-1022
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| "@scality/cloudserverclient": "1.0.13", | ||
| "@scality/scubaclient": "1.2.1", | ||
| "@scality/utapi": "github:scality/utapi#8.4.0", | ||
| "@scality/utapi": "github:scality/utapi#d5f383e6da23b66d7cf2be52bf8f3383d89e7356", |
There was a problem hiding this comment.
utapi is pinned to a commit SHA, not a release tag. Git deps must pin to a tag. Bump to the utapi release tag that includes scality/utapi#1339 (and regenerate yarn.lock) before merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 203 files with indirect coverage changes @@ Coverage Diff @@
## development/9.5 #6327 +/- ##
===================================================
+ Coverage 87.87% 90.22% +2.35%
===================================================
Files 206 206
Lines 14193 38590 +24397
===================================================
+ Hits 12472 34818 +22346
- Misses 1721 3772 +2051
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Clean up the remaining CVEs in cloudserver's dependencies and image.
@hapi/joitojoi.requestand oldjsonwebtoken. That makes our resolutions for that chain unnecessary.osv-scanner on yarn.lock goes from 13 findings to 2, both dev-only with no fix available yet (braces, katex).
Issue: CLDSRV-1022