fix: Use the object form paramsSerializer in the request url - #1015
Open
razor-x wants to merge 3 commits into
Open
fix: Use the object form paramsSerializer in the request url#1015razor-x wants to merge 3 commits into
razor-x wants to merge 3 commits into
Conversation
The url getter only honored a function form paramsSerializer and silently fell back to the SDK serializer for the object form axios also accepts, so the inspected request URL diverged from the URL actually sent on the wire. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2
…izer Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK audit finding L8a (low): the
SeamHttpRequest.urlgetter only honored a function-formparamsSerializerand silently fell back to Seam's serializer when the user configured axios's object form ({ serialize, encode, indexes }). Axios itself uses the object form when sending, so the inspectedrequest.urldiverged from the wire URL — debug output lying about the request.Fix
The getter now also uses
paramsSerializer.serializewhen the object form is configured, falling back to the SDK serializer only when neither form is present (the SDK default).Tests
Both custom forms pinned: a function-form serializer and an object-form serializer each control
request.url's query. The object-form test fails on reverted source (falls back to the SDK serializer). Full suite (127 tests), lint, typecheck green.Part of applying the rev-3 SDK audit (one PR per finding). Related: #1002–#1014.
🤖 Generated with Claude Code
https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2
Generated by Claude Code