Repository navigation
fix: update Kazakhstan, Ethiopia, Norway and Equatorial Guinea data - #111
Merged
deanology merged 1 commit intoOct 8, 2026
Conversation
- Kazakhstan: current ISO 3166-2:KZ subdivisions (2022 update), with Astana instead of Nur-Sultan, the new Abai, Jetisu and Ulytau regions, and the numeric codes; restore the native name, which was "?????????". - Ethiopia: add South West Ethiopia Peoples' Region (ET-SW). - Norway: use the real ISO 3166-2:NO county codes. - Equatorial Guinea: capital is Ciudad de la Paz. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geographybuff
marked this pull request as ready for review
October 8, 2026 15:39
Owner
|
I will take a look into this |
eanolue
approved these changes
Oct 8, 2026
deanology
approved these changes
Oct 8, 2026
Owner
|
We will deploy a new release by weekend @geographybuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates four countries whose data is out of date. Each change is in the country file and its unit test (8 files).
Kazakhstan (
Kazakhstan.cs,KazakhstanTest.cs)KZ-NUR). The city was renamed back to Astana on 17 September 2022 (Al Jazeera, Wikipedia).KZ-NURwas never an ISO code.KZ-AKM→KZ-11,KZ-ALA→KZ-75), so the list now uses the current codes: 17 regions + 3 cities, 20 entries (ISO 3166-2:KZ). Every Kazakhstan code changes, so anything matching on the old codes would need updating.NativeNamewas the literal string"?????????", an encoding loss; it's now"Қазақстан". Kazakhstan was the only country affected.Ethiopia (
Ethiopia.cs,EthiopiaTest.cs)SW), which ISO 3166-2:ET added on 2022-11-29 (ISO 3166-2:ET, Regions of Ethiopia). SNNPR (SN) stays, because ISO still lists it.Norway (
Norway.cs,NorwayTest.cs)NO-01…NO-11, which don't match ISO 3166-2:NO (for example Viken wasNO-11, ISO's code for Rogaland). They now use the ISO codes, such as AgderNO-42, OsloNO-03, VikenNO-30(ISO 3166-2:NO). The county names are unchanged: Norway split Viken, Vestfold og Telemark and Troms og Finnmark in January 2024, but ISO 3166-2 hasn't adopted that yet.Equatorial Guinea (
EquatorialGuinea.cs,EquatorialGuineaTest.cs)Tests:
dotnet testpasses (252 tests).AI disclosure: prepared with Claude Code (Claude Opus 5.5), which found the outdated entries, checked them against the sources above, made the edits and ran the tests.