Repository navigation
feat: implement schemars for smallvec - #813
Merged
Merged
Conversation
GauravPawar101
force-pushed
the
schemars
branch
from
October 28, 2026 10:34
aebfd5a to
b1a8cc5
Compare
alejandro-vaz
self-requested a review
October 28, 2026 10:36
alejandro-vaz
approved these changes
Oct 28, 2026
| for SmallVec<Item, INLINE, Heap> | ||
| { | ||
| fn inline_schema() -> bool { | ||
| <alloc::vec::Vec<Item> as JsonSchema>::inline_schema() |
Collaborator
There was a problem hiding this comment.
I don't like it but I don't think we have any alternative
Collaborator
There was a problem hiding this comment.
I'll think about it
Collaborator
|
btw what's your email address?? so we can communicate over there as well?? send me an email better instead |
Collaborator
|
miri and tests fail |
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
GauravPawar101
force-pushed
the
schemars
branch
from
October 28, 2026 10:55
b1a8cc5 to
ccd1f71
Compare
alejandro-vaz
requested changes
Oct 28, 2026
Collaborator
Author
|
No, it’s that the element type of |
alejandro-vaz
approved these changes
Oct 28, 2026
alejandro-vaz
left a comment
alejandro-vaz
left a comment
Collaborator
There was a problem hiding this comment.
👍, it doesn't matter much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #799