Repository navigation
feat: rkyv implementation for smallvec - #814
Merged
Merged
Conversation
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
alejandro-vaz
requested changes
Oct 28, 2026
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
alejandro-vaz
requested changes
Oct 28, 2026
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
Collaborator
Author
|
Miri is expected to fail:
Been hitting this for almost an hour |
Collaborator
|
then tell miri to stfu like we do in |
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
alejandro-vaz
approved these changes
Oct 28, 2026
alejandro-vaz
requested changes
Oct 28, 2026
Collaborator
Author
|
To not embaras ourselves we should use something like bors, to squash these like rust-lang. |
Collaborator
|
hahahahhahha fair, no G squash merging is the only type of merge allowed so don't worry I'm not sure how you'd set up bors I think we shouldn't. it'd add complexity and the ROI is basically zero btw review #815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #798