Repository navigation
fix(cli): only compare release numbers in the minimum version check - #22
Merged
Merged
Conversation
cvl
commented
Oct 21, 2026
cvl
commented
Contributor
- fix(cli): only compare release numbers in the minimum version check
A binary labelled from git describe picks up the nearest tag. With the skills-v1.0.0 tag on main that label is "skills", which parsed as 0.0.0 and was refused as older than the minimum required version, so a build from main could not start the interactive shell. Only a plain X.Y.Z version is compared now; "dev" and any other label skip the check, as "dev" already did. Release builds are unaffected. Signed-off-by: Vitas Civilis <vytautas@civilis.lt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.