Repository navigation
feat(proxy): take proxy credentials exactly as written - #26
Merged
Merged
Conversation
cvl
commented
Oct 22, 2026
cvl
commented
Contributor
- test(proxy): keep the URL parser tests next to the parser
- docs: proxy credentials are taken as written; 0.2.1 changelog entry
- feat(proxy): take proxy credentials exactly as written
The username and password in a proxy URL are no longer passed through net/url: the text before the last @ is the credentials, split once at the first colon, and sent byte for byte over Basic and SOCKS5 authentication. Entries saved by earlier versions keep their percent-encoded form and are decoded; new entries carry a literal marker. The redactor splits the same way and validates the host part, so no password byte can appear in output. When a proxy rejects the login or the shell splits an unquoted URL, the error says what to do: quote the URL, or write the real characters instead of a percent-encoded password. SOCKS5's 255-byte credential limit is checked when the URL is parsed, not only when connecting. Signed-off-by: Vitas Civilis <vytautas@civilis.lt>
Signed-off-by: Vitas Civilis <vytautas@civilis.lt>
Signed-off-by: Vitas Civilis <vytautas@civilis.lt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.