Repository navigation
fix(copilot): read sandbox paths in files view and admit missing overwrite targets in multi-file exports - #9200
Merged
waleedlatif1 merged 1 commit intoOct 18, 2026
Conversation
…write targets in multi-file exports
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryRoutes absolute sandbox paths in
|
waleedlatif1
deleted the
fix/copilot-file-view-sandbox-and-overwrite-create
branch
October 18, 2026 22:12
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files viewnow routes absolute sandbox paths (/tmp/...,/home/user/...) to the same authorized chat scratch readerfiles readuses, rendered visually like theuploads/branch. Before, they fell through to the workspace lookup and returned a misleading "File not found"isScratchReferenceinscratch-file-read.tssofiles readandfiles viewshare one definitionvalidateWorkspaceFileWriteTargetnow treats a not-found overwrite target as a create (same admission and target resolution as the create branch, reported asmode: 'create'), matchingwriteWorkspaceFileByPath, which has upserted since improvement(mothership): mothership v0.9 #6815. Before, a multi-filerun_functionexport withmode: "overwrite"for a path that didn't exist yet failed up front with "File not found" after the user's code had already runType of Change
Testing
file-view.test.ts:files view /home/user/x.pngreaches the scratch reader and never the workspace lookup (red with the guard reverted: workspace artifact read called)resource-writer.test.ts: overwrite validation of a missing target resolves as create, and still refuses when create admission is denied (red with the guard reverted: rejects "File not found")overwrite-export.integration.ts(real Postgres): a two-file Function export with an overwrite target in an empty folder creates the file; an existing overwrite target is still replaced in placefile-read.test.ts,execute-request.test.tspass;check:test-patterns,check:comment-hygiene,check:file-namespassChecklist
test-auditauthoring gate)